Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy settings as JSON string to another instance of the app #1299 #1339

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NirobNabil
Copy link

@NirobNabil NirobNabil commented Mar 6, 2023

Adresses feature request #1299

A copy over button to export and share my custom settings with teammates or coworkers conveniently.

Work done:

  • A copy button on options popup to copy the current settings to clipboard as a JSON string
  • A paste button on the options popup to load JSON formatted settings from clipboard ( currently not supported in firefox )
  • Currently just disabling the functionality on firefox if navigator.clipboard.readText is not available

I'm willing to work further on polishing this feature if this feature is desirable enough to be merged with main. so i'm adding the work remaining section and asking for feedback on what i can improve.

Work remaining:

  • Didn't add the functionality on mobile view yet
  • It is possible to add a textbox for user to manually paste the copied JSON string and then load it from there for browsers where the clipboard.readText api is not supported.

Feedback needed -

  • Added two icons for copy and paste which both occupy 1.3kb which seems too big for just a simple icon. i could try png but i noticed almost every icon in the site uses svg so kept the svg ones. Let me know if there are smaller/better svg icons or if i should try png/webp icons.
  • The copy and paste buttons are positioned so that the buttons are always at the top of the options popup ( which is part of the processor settings ) But by default processor settings part is hidden and only encoder settings part is visible so as a result the paste button is also invisible by default. it is only visible when user chooses an encoder. Should i keep it as it is or move the buttons to encoder settings section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant