Update JXL to v0.7.0 #1378
Draft
Update JXL to v0.7.0 #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds an example.html to codecs/jxl
Compiles successfully Finishes decoding successfully Throws an error on returning from WASM to the JS glue code
Commented out lines 247 - 249 in codecs\jxl\node_modules\jxl\CMakeLists.txt Compiles successfully WASM decoding finishes successfully Runs successfully
aryanpingle
force-pushed
the
wasmstuff
branch
from
7293d4c to
8178db1
Compare
|
This commit in the libjxl repo enables On building this version of JXL, our WASM files are generated, the decoder finishes executing correctly (as seen in the console debug statement), but the JS glue code fails with the following error:
Commenting out the section in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.