manual const ref conversions

clang-tidy found these but was not able to automatically fix them. Signed-off-by: Rosen Penev <[email protected]>
GothenburgBitFactory · Jun 26, 2023 · b41bb63 · b41bb63
1 parent 734971b
commit b41bb63
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Packrat.cpp b/src/Packrat.cpp
@@ -79,7 +79,7 @@ void Packrat::entity (const std::string& category, const std::string& name)
 ////////////////////////////////////////////////////////////////////////////////
 void Packrat::external (
   const std::string& rule,
-  bool (*fn)(Pig&, std::shared_ptr <Tree>))
+  bool (*fn)(Pig&, const std::shared_ptr <Tree>&))
 {
   if (_externals.find (rule) != _externals.end ())
     throw format ("There is already an external parser defined for rule '{1}'.", rule);

diff --git a/src/Packrat.h b/src/Packrat.h
@@ -37,7 +37,7 @@ class Packrat
 public:
   void parse (const PEG&, const std::string&);
   void entity (const std::string&, const std::string&);
-  void external (const std::string&, bool (*)(Pig&, std::shared_ptr <Tree>));
+  void external (const std::string&, bool (*)(Pig&, const std::shared_ptr <Tree>&));
 
   void debug ();
   std::string dump () const;
@@ -62,7 +62,7 @@ class Packrat
   std::map <std::string, PEG::Rule>                              _syntax   {};
   std::shared_ptr <Tree>                                         _tree     {std::make_shared <Tree> ()};
   std::multimap <std::string, std::string>                       _entities {};
-  std::map <std::string, bool (*)(Pig&, std::shared_ptr <Tree>)> _externals {};
+  std::map <std::string, bool (*)(Pig&, const std::shared_ptr <Tree>&)> _externals {};
 };
 
 #endif

diff --git a/test/external.t.cpp b/test/external.t.cpp
@@ -33,7 +33,7 @@
 #include <Tree.h>
 
 ////////////////////////////////////////////////////////////////////////////////
-bool externalParser (Pig& pig, std::shared_ptr <Tree> branch)
+bool externalParser (Pig& pig, const std::shared_ptr <Tree>& branch)
 {
   if (pig.skipLiteral ("foo"))
   {