Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test runs after recent gh/docker/cmake changes #82

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

smemsh
Copy link
Contributor

@smemsh smemsh commented Aug 14, 2024

A couple fixes to get the test runner working again:

  • Github has retired "docker-compose" (ie v1) and now requires to be invoked as "docker compose". See url to a discussion in the commit message.
  • Also there were some recent changes to Taskwarrior cmake rules whilst making C++ tests run with a single executable, which now requires a trivial change in the docker file.

After these fixes, the tests work again.

Apparently "docker-compose" was deprecated over 6 months ago and is
starting to be phased out in favor of "docker compose".  Without this,
test runners are getting:

  home/runner/work/_temp/0af6641a-337b-4651-8ca4-fef3529091af.sh: line 1:
  docker-compose: command not found

See https://github.com/orgs/community/discussions/116610 for details
…nges

This fixes integration tests to deal with with a recent change to cmake
targets used to run all C++ tests from a single executable.
@smemsh
Copy link
Contributor Author

smemsh commented Aug 14, 2024

@djmitche maybe this is your area?

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks familiar!

@djmitche djmitche merged commit 1525e58 into GothenburgBitFactory:master Aug 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants