Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem: move to libsassc #209

Merged
merged 1 commit into from
Aug 20, 2019
Merged

gem: move to libsassc #209

merged 1 commit into from
Aug 20, 2019

Conversation

freesteph
Copy link
Contributor

@freesteph freesteph commented Aug 19, 2019

The sass ruby gem is deprecated and libsassc (gem name: sassc)
is a much-faster, drop-in replacement.

Unfortunately middleman-sprockets isn't always happy with the new
gem1 so include the old one as well in the bundle.

As per the code changes, point towards a standard and IE-specific
manifests, which in turn include the GOV.UK Frontend assets with the
correct ie-specific variables set in the latter case.

(re)compile-time greatly reduced.

The `sass` ruby gem is deprecated and `libsassc` (gem name: `sassc`)
is a much-faster, drop-in replacement.

Unfortunately `middleman-sprockets` isn't always happy with the new
gem[1] so include the old one as well in the bundle.

As per the code changes, point towards a standard and IE-specific
manifests, which in turn include the GOV.UK Frontend assets with the
correct ie-specific variables set in the latter case.

(re)compile-time greatly reduced.

[1]: middleman/middleman-sprockets#132
@freesteph freesteph force-pushed the feature/move-to-sassc branch from c326cf0 to 1688c07 Compare August 20, 2019 12:38
@freesteph freesteph requested a review from robinmitra August 20, 2019 12:54
@quis
Copy link
Contributor

quis commented Aug 20, 2019

This will make my life noticeably more pleasant. Thanks.

Copy link
Contributor

@robinmitra robinmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@freesteph freesteph merged commit b31297b into master Aug 20, 2019
@freesteph freesteph deleted the feature/move-to-sassc branch August 20, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants