Make ore prospector place waypoints at vein height #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change ore prospector behavior to place waypoints at the average height of the hovered ores instead of at the surface. Also adds the height to the tooltip, might be too cluttered?
Implementation Details
The height of each ore in the prospecting packet is averaged and stored in a map entry per oredict, then the currently hovered ores are averaged again and stored in a member which later gets used when adding the waypoint. I mostly copied the way oreInfo and hoveredNames was done. Height is already given in the keys of the packet, so there should be no performance impact.
Outcome
When the player adds a waypoint, it gets placed directly at the height of the vein. Less tedious than having to look it up in jei or blindly mining up or down.
Additional Information
Potential Compatibility Issues
Not much, all changes are isolated to WidgetProspectingMap. If no ores are found it defaults to the surface, so fluid prospector behavior is unchanged.