Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify hessian_tensor_product, removing numpy dependency #348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify hessian_tensor_product, removing numpy dependency #348

wants to merge 1 commit into from

Conversation

j-towns
Copy link
Collaborator

@j-towns j-towns commented Jan 3, 2018

No description provided.

@j-towns
Copy link
Collaborator Author

j-towns commented Jan 4, 2018

The test failures appear to have been caused by an issue with Travis/Github.

@mattjj
Copy link
Contributor

mattjj commented Feb 24, 2018

Nice simplification! But should we just remove this function? Your revision makes clear that it's redundant with make_hvp.

@j-towns
Copy link
Collaborator Author

j-towns commented Feb 27, 2018 •
edited
Loading

Hmm, I can think of at least one downstream project that likes to use hessian_vector_product, maybe a compromise would be to re-implement this as a wrapper around make_hvp (not sure why I didn't already do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-towns @mattjj