Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS .pkg improvements #15751

Merged
merged 1 commit into from
Jul 25, 2023
Merged

macOS .pkg improvements #15751

merged 1 commit into from
Jul 25, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 25, 2023

Screenshot 2023-07-25 at 15 33 42
  • don't include GitHub Actions credentials
  • generate and include RTF version of Homebrew BSD license
  • create nicer installer with productbuild
  • customise welcome/conclusion messages
  • add Homebrew logo as a background image
  • remove unnecessary preinstall script
  • cleanup postinstall script to pass brew doctor
  • use Distribution.xml for a nicer installer
  • require CLT or Xcode rather than using our hacks to try and install CLT during installation

@MikeMcQuaid MikeMcQuaid force-pushed the pkg_improvements branch 8 times, most recently from 8b3b928 to b7b1922 Compare July 25, 2023 14:16
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 25, 2023
- don't include GitHub Actions credentials
- generate and include RTF version of Homebrew BSD license
- create nicer installer with `productbuild`
- customise welcome/conclusion messages
- add Homebrew logo as a background image
- remove unnecessary `preinstall` script
- cleanup `postinstall` script to pass `brew doctor`
- use `Distribution.xml` for a nicer installer
- require CLT or Xcode rather than using our hacks to try and install
  CLT during installation
@MikeMcQuaid MikeMcQuaid merged commit 714cd07 into master Jul 25, 2023
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the pkg_improvements branch July 25, 2023 15:01
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants