Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-installer: don't build on Dependabot PR's #17976

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane commented Aug 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Dependabot does not have access to secrets, which causes jobs like this to fail: https://github.com/Homebrew/brew/actions/runs/10272120887/job/28423593171?pr=17971

@p-linnane p-linnane changed the title pkg-installed: don't build on Dependabot PR's pkg-installer: don't build on Dependabot PR's Aug 6, 2024
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @p-linnane!

@MikeMcQuaid MikeMcQuaid merged commit 90a90b3 into master Aug 7, 2024
30 checks passed
@MikeMcQuaid MikeMcQuaid deleted the update-pkg-build branch August 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants