Vendor SBOM schema #17981
Merged
Vendor SBOM schema #17981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thanks @Bo98! Good to go as-is to unbreak things but let's talk about review comments for a follow-up.
Bo98
force-pushed
the
sbom-schema-offline
branch
2 times, most recently
from
0092230
to
853d6a3
Compare
Bo98
force-pushed
the
sbom-schema-offline
branch
from
853d6a3
to
040372f
Compare
carlocab
approved these changes
Aug 7, 2024
|
Turns out validation has never really worked properly. Will merge this as-is to unblock things as it maintains the status quo but need to investigate this much further. |
|
Thanks @Bo98! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a core part of our CI now. We don't want the remote end changing under us randomly. Vendor it properly with CI testing.