Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: remove duplicate step #18292

Closed
wants to merge 1 commit into from
Closed

workflows/tests: remove duplicate step #18292

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 9, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is already done in the formula-audit job:

- name: Generate formula API
run: brew generate-formula-api --dry-run

Comment on lines -181 to -182
- name: Generate formula API
run: brew generate-formula-api --dry-run
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, I see. This step runs on macOS, but the other one runs on Linux. Do we really need both?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab Yes. This was added by when we had formulae generation failing on one platform but not another.

@carlocab carlocab closed this Sep 9, 2024
@carlocab carlocab deleted the ci-dupe branch September 9, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants