Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/pkgconfig/14: update libcurl for 14.5 SDK #18298

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Sep 9, 2024

macOS 14.5 SDK has been an Xcode-exclusive SDK until now, so we never updated this pc file. CLT 16 will however include macOS 14.5 SDK so we can update this now.

While the 8.6.0 runtime supports NTLM_WB, the 8.6.0 curl-config dropped the reference to it ahead of Apple dropping it in macOS 14.6's curl 8.7.1 update, which never received a corresponding SDK. Not reporting a feature seems like the safest option.

This PR may have to wait until after the CLT is released fully.

@Bo98 Bo98 marked this pull request as draft September 9, 2024 23:23
@Bo98
Copy link
Member Author

Bo98 commented Sep 9, 2024

This PR may have to wait until after the CLT is released fully.

CI agrees. If you see the CI here suddenly break in a couple weeks then this is the PR to merge to fix it.

@carlocab
Copy link
Member

Seeing

Failures:

  1) pkg-config returns the correct version for libcurl
     Failure/Error: expect(pc_version("libcurl")).to eq(version)

       expected: "8.6.0"
            got: "8.4.0"

       (compared using ==)
     # ./test/os/mac/pkgconfig_spec.rb:53:in `block (2 levels) in <top (required)>'

in CI now.

https://github.com/Homebrew/brew/actions/runs/10958495800/job/30428868352?pr=18364#step:12:118

@carlocab carlocab marked this pull request as ready for review September 20, 2024 11:46
@MikeMcQuaid MikeMcQuaid merged commit d8fd19d into master Sep 20, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the curl-14.5 branch September 20, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants