Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_runner_matrix: include 15-x86_64 with --all-supported #18362

Merged
merged 1 commit into from
Sep 19, 2024
Merged

github_runner_matrix: include 15-x86_64 with --all-supported #18362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/github_runner_matrix.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def generate_runners!
)
@runners << create_runner(:macos, :arm64, spec, macos_version)

next if macos_version > NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER
next if !@all_supported && macos_version > NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth renaming NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER, though not really sure what name suits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah though not really sure either

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWEST_HOMEBREW_CORE_INTEL_MACOS_RUNNER_MOST_OF_THE_TIME


github_runner_available = macos_version <= NEWEST_GITHUB_ACTIONS_INTEL_MACOS_RUNNER &&
macos_version >= OLDEST_GITHUB_ACTIONS_INTEL_MACOS_RUNNER
Expand Down
Loading