Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bottling Portable Ruby for ARM64 Linux #19111

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Add support for bottling Portable Ruby for ARM64 Linux #19111

merged 1 commit into from
Jan 19, 2025

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These are the things that I identified when playing with Portable Ruby on ARM64 Linux.

@ZhongRuoyu ZhongRuoyu requested a review from Bo98 January 17, 2025 00:11
Bo98
Bo98 reviewed Jan 17, 2025
View reviewed changes
Library/Homebrew/shims/super/cc Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/linux/extend/ENV/super.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Most of this should be good to go 🔜

Library/Homebrew/extend/os/linux/extend/ENV/super.rb Outdated Show resolved Hide resolved
Library/Homebrew/extend/os/linux/extend/ENV/super.rb Outdated Show resolved Hide resolved
Library/Homebrew/shims/super/cc Outdated Show resolved Hide resolved
Library/Homebrew/shims/super/cc Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 19, 2025
Merged via the queue into master with commit 0c1abc1 Jan 19, 2025
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the aarch64-linux branch January 19, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 left review comments

@carlocab carlocab carlocab approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhongRuoyu @MikeMcQuaid @Bo98 @carlocab