Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

casks-without-zap: update script #160914

Merged
merged 1 commit into from
Nov 24, 2023
Merged

casks-without-zap: update script #160914

merged 1 commit into from
Nov 24, 2023

Conversation

razvanazamfirei
Copy link
Member

Bug fixes and improvements:

  1. Implemented the Find.find method for recursive directory traversal, enabling the script to locate cask files in subdirectories based on the first letter of the cask name. This is consistent with the new repository structure.
  2. Modified the logic that identifies casks without a zap stanza or marked as discontinued. Previously, each file was read twice to check these conditions.

See also: #88469 (comment)

@bevanjkay bevanjkay merged commit f5eda96 into Homebrew:master Nov 24, 2023
6 checks passed
@razvanazamfirei razvanazamfirei deleted the casks-without-zap branch November 26, 2023 02:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bevanjkay bevanjkay bevanjkay approved these changes

Assignees
No one assigned
Labels
automerge-skip outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvanazamfirei @bevanjkay @BrewTestBot