fix livecheck of Google Chrome #175494
Closed
fix livecheck of Google Chrome #175494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron-212 <[email protected]>
bevanjkay
reviewed
Jun 1, 2024
| strategy :extract_plist do |versions| | ||
| versions.values.filter_map(&:short_version).first | ||
| end | ||
| url "https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Mac" |
There was a problem hiding this comment.
This has been used previously, but caused issues
There was a problem hiding this comment.
What about this url?
https://chromiumdash.appspot.com/releases?platform=Mac
There was a problem hiding this comment.
The concern is because the download url is disconnected to these feeds, and this is updated regularly. The livecheck is likely to often be out of sync at audit time.
This may be a rare case where extract_plist is actually the best option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Related to #171006
Do we need to add Google Chrome to autobump.txt?