Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstore-quickview: disable #178641

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

khipp
Copy link
Member

@khipp khipp commented Jul 5, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The last update was in 2012.

Related to #171006.

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jul 5, 2024
@krehel
Copy link
Member

krehel commented Jul 5, 2024

This no longer appears to be functional. Can you mark disabled? Thanks.

@khipp khipp force-pushed the update-appstore-quickview branch from a8238c9 to 6a43be6 Compare July 5, 2024 18:44
@khipp khipp changed the title appstore-quickview: deprecate appstore-quickview: disable Jul 5, 2024
@khipp khipp force-pushed the update-appstore-quickview branch from 6a43be6 to 9c815e2 Compare July 5, 2024 18:47
@p-linnane p-linnane added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jul 5, 2024
@p-linnane p-linnane enabled auto-merge July 5, 2024 19:01
@p-linnane p-linnane merged commit 2814312 into Homebrew:master Jul 5, 2024
9 of 11 checks passed
@khipp khipp deleted the update-appstore-quickview branch July 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. missing zap Cask is missing a zap stanza, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants