Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimobiledevice-glue 1.0.0 #143555

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

TheRealKeto
Copy link
Contributor

@TheRealKeto TheRealKeto commented Sep 18, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Since libplist 2.3.0 was recently merged in #142057, we can move forward with adding libimobiledevice-glue. As the description suggests, the formula is a library that is commonly used with libimobiledevice projects, and is a dependency moving foward.

All of these changes are based on the discussions of previous attempts at updating/adding these formulae.

@SMillerDev
Copy link
Member

Can you split out the new formula and new dependencies into separate pull requests.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 18, 2023
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheRealKeto ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@chenrui333
Copy link
Member

great work! 💯

@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 20, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 20, 2023
Merged via the queue into Homebrew:master with commit 9d1a713 Sep 20, 2023
12 checks passed
@TheRealKeto TheRealKeto deleted the feat/libimobiledevice-glue branch September 20, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants