-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libimobiledevice-glue 1.0.0 #143555
libimobiledevice-glue 1.0.0 #143555
Conversation
c1ccb8f
to
81f8f54
Compare
Can you split out the new formula and new dependencies into separate pull requests. |
81f8f54
to
cd4e81e
Compare
cd4e81e
to
db0b8b9
Compare
db0b8b9
to
9ec6ed1
Compare
9ec6ed1
to
93dff63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheRealKeto ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
great work! 💯 |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Since libplist 2.3.0 was recently merged in #142057, we can move forward with adding
libimobiledevice-glue
. As the description suggests, the formula is a library that is commonly used with libimobiledevice projects, and is a dependency moving foward.All of these changes are based on the discussions of previous attempts at updating/adding these formulae.