Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopsy 4.21.0 #190813

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

autopsy 4.21.0 #190813

wants to merge 1 commit into from

Conversation

xakep8
Copy link
Contributor

@xakep8 xakep8 commented Sep 16, 2024

This commit is part of issue #139929. It upgrades the autopsy formula.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added perl Perl use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Sep 16, 2024
@xakep8 xakep8 force-pushed the autopsy_upgrade branch 3 times, most recently from fce2d3c to 8f19b37 Compare September 16, 2024 14:41
@github-actions github-actions bot removed the formula deprecated Formula deprecated label Sep 16, 2024
@carlocab carlocab changed the title autopsy: upgrading autopsy formula to 4.21.0 autopsy 4.21.0 Sep 16, 2024
Formula/a/autopsy.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added java Java use is a significant feature of the PR or issue missing license Formula has a missing license which should be added and removed perl Perl use is a significant feature of the PR or issue labels Sep 16, 2024
@xakep8 xakep8 force-pushed the autopsy_upgrade branch 2 times, most recently from 65efbe7 to 44ee7e3 Compare September 16, 2024 23:16
@github-actions github-actions bot removed the missing license Formula has a missing license which should be added label Sep 16, 2024
Comment on lines -23 to -24
# Installs prebuilt binaries, broken on arm: https://github.com/Homebrew/homebrew-core/issues/175053
deprecate! date: "2024-06-22", because: :does_not_build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, but it looks like the reason we deprecated it still applies:

  autopsy
    * Binaries built for a non-native architecture were installed into autopsy's prefix.
      The offending files are:
        /opt/homebrew/Cellar/autopsy/4.21.0/libexec/autopsy/markmckinnon/Export_srudb_macos	(x86_64)
        /opt/homebrew/Cellar/autopsy/4.21.0/libexec/autopsy/markmckinnon/parse_prefetch_macos	(x86_64)
        /opt/homebrew/Cellar/autopsy/4.21.0/libexec/platform/modules/lib/x86_64/libjnidispatch-nb.jnilib	(x86_64)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab the formula is still being worked on I was just testing what was the issue with the old formula

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem! Please feel free to continue working on this.

When you feel that this PR is close to ready, please edit your commit message to read

autopsy 4.21.0

Thanks!

This commit is part of issue Homebrew#139929. It upgrades the autopsy formula.

style fix

style fix

autopsy: removed the deprecated label.

autopsy: testing the old code and checking where it fails.

fixed style issues

added license.

trying to fix the issue on arm64

added zlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants