Copy hostname and IP when clicked (#182) #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR due to inactivity since mid-2019. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In advance, this pull request might have a merge conflict with #174
In addition to the suggestion in #182 to copy the IP, I also made the hostname copyable.
Because Hyperline decorated the Hyper instead of the Term component, and used absolute positioning, the "onClick" event handler wasn't executed. This is why I decided to decorate the Term component so that the console part doesn't overlap with the Hyperline component and is still at the bottom.
^ ppssstt, the IP is made up by my beautiful imagination capabilities