Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFD Extraction Transformation. #135

Merged
merged 5 commits into from
Feb 14, 2025
Merged

GFD Extraction Transformation. #135

merged 5 commits into from
Feb 14, 2025

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Feb 6, 2025 •
edited
Loading

Changes

  • Add extraction and transformation for Global Flood Database.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/global_flood_database branch 3 times, most recently from 9761943 to 0e449fe Compare February 6, 2025 11:34
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review February 6, 2025 12:05
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/global_flood_database branch from 0e449fe to c79a535 Compare February 6, 2025 12:08
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/global_flood_database branch from c79a535 to 6d6ff2a Compare February 11, 2025 05:02
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/global_flood_database branch 4 times, most recently from a591837 to 1951d20 Compare February 11, 2025 06:11
susilnem
susilnem approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes! Otherwise LGTM!

apps/etl/extraction/sources/gfd/extract.py Outdated Show resolved Hide resolved
apps/etl/extraction/sources/gfd/extract.py Outdated Show resolved Hide resolved
apps/etl/management/commands/extract_gfd_data.py Outdated Show resolved Hide resolved
apps/etl/management/commands/extract_gfd_data.py Outdated Show resolved Hide resolved
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/global_flood_database branch from 1951d20 to 15173a6 Compare February 13, 2025 11:00
@ranjan-stha ranjan-stha merged commit b3cd08f into develop Feb 14, 2025
3 checks passed
@ranjan-stha ranjan-stha deleted the feature/global_flood_database branch February 14, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@thenav56 thenav56 Awaiting requested review from thenav56

@subinasr subinasr Awaiting requested review from subinasr

@ranjan-stha ranjan-stha Awaiting requested review from ranjan-stha

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rup-Narayan-Rajbanshi @susilnem @ranjan-stha