External tools #11
Open
External tools #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th database migration scripts
…em, along with related model and controller updates
…or handling tool manifests
…tabase and version metadata models
…database resource storage, including updates to ExternalToolManifest handling and repository definitions.
…e storage type definitions
… for filesystem storage support
…ternalToolService to handle image storage
… handle item images
…d tool functionality and update request examples
…for the Ask the Data tool
…and RoleCreationRequest
…uest models and repository methods
…ad and delete endpoints
…t and manifest handling
…e management and API documentation
…addition and image handling
…ionDTO, and enhance ExternalToolVersionController with caching and authorization
…ng database migration
Merged
pdurbin
reviewed
Feb 25, 2025
| */ | ||
| @GetMapping() | ||
| @ExternalToolsAPIDocs.ExternalToolsListDoc | ||
| public ResponseEntity<?> getAllTools() { |
There was a problem hiding this comment.
This API endpoint doesn't seem to work for me. Getting just one tool works, but not all. I just get an empty array.
pdurbin@beamish dataverse-marketplace % curl -s http://localhost:8080/api/tools/1 | jq .
{
"id": 1,
"name": "AskTheData",
"description": "Ask the Data is an ...",
"versions": [
{
"id": 1,
"version": "1.0",
"releaseNote": "This release includes a new feature ...",
"dataverseMinVersion": "6.0",
"manifests": [
{
"manifestId": 2,
"storedResourceId": 5
}
]
}
],
"imagesResourceId": [
3
]
}
pdurbin@beamish dataverse-marketplace % curl -s http://localhost:8080/api/tools | jq .
[]
pdurbin@beamish dataverse-marketplace %
There was a problem hiding this comment.
That is weird, I been using that endpoint for the main page and it works fine, I will do a fresh test soon and post back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces 16 new endpoints to manage external tools and their versions in the Dataverse-Marketplace application.
New Features:
New Endpoints:
Tools:
✅*
[GET] /api/tools✅*
[POST] /api/tools✅*
[GET] /api/tools/{toolId}✅*
[PUT] /api/tools/{toolId}Versions:
✅*
[GET] /api/tools/{toolId}/versions✅*
[POST] /api/tools/{toolId}/versions✅*
[GET] /api/tools/{toolId}/versions/{versionId}✅*
[PUT] /api/tools/{toolId}/versions/{versionId}✅*
[DELETE] /api/tools/{toolId}/versions/{versionId}Images:
✅*
[GET] /api/tools/{toolId}/images✅*
[POST] /api/tools/{toolId}/images✅*
[DELETE] /api/tools/{toolId}/images/{imageId}Manifest
✅*
[GET] /api/tools/{toolId}/versions/{versionId}/manifests✅*
[POST] /api/tools/{toolId}/versions/{versionId}/manifests✅*
[DELETE] /api/tools/{toolId}/versions/{versionId}/manifests/{manifestId}Stored Resource
[GET] /api/stored-resource/{resourceId}New Tests:
Closes: