Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Team Page Scrolling Animation #355

Open
wants to merge 7 commits into
base: migration
Choose a base branch
from

Conversation

BeckyBlake
Copy link
Contributor

Status:

🚀 Ready

Description

  • Added Marketing Committee to team page
  • Added overflow:hidden to .main container to fix the horizontal scrolling problem. Since adding overflow: hidden interfered with the inner containers' 'position: sticky', I used gsap scrolling to simulate stickiness. Basically as the user scrolls, the inner containers' marginTop increases, pushing it down with the viewport. It's not as smooth as 'position: sticky' imo, but it allows for overflow: hidden to fix the horizontal scrolling problem
  • Direction of horizontal animation switches with every committee

Screenshots

Marketing Committee:
Screenshot 2025-02-16 at 9 33 22 PM
Screenshot 2025-02-16 at 9 33 33 PM

@BeckyBlake BeckyBlake requested a review from inolasv February 17, 2025 03:34
Copy link
Collaborator

@inolasv inolasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey some comments before i look at your code:

  • it looks like the transitions are not as smooth as they used to be
  • the marketing team pic is a little stretched
  • i think that the descriptions got a little smaller width-wise than they were

if its too much to add the alternating and also keep it as smooth, lmk and it should be find if you just switch the order of the pic/description instead of alternating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants