Improvement: CMEK Additions and Normalization #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR adds two new CMEK endpoints to retrieve a key by ID and name. In addition, all CMEK endpoints have been updated to return the key with the
versionandencryptionAlgorithmproperites to normalize responses (previously only list keys did this).isReservedhas also been omitted as it is not informative to the user. Minor CMEK UI adjustments.In addition the
slugcolumn on thekms_keystable has been removed.Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets