Feature: Databricks Connection & Sync #3099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,4 @@ | |||
| import { registerDatabricksSyncRouter } from "@app/server/routes/v1/secret-sync-routers/databricks-sync-router"; | |||
There was a problem hiding this comment.
nit - let's be consistent with the imports?
| helperText={ | ||
| <Tooltip | ||
| className="max-w-md" | ||
| content="Ensure that you've created the secret scope in the selected workspace, the service principal has been be assigned to the respective workspace and that your service principal has write permissions for the specified secret scope." |
There was a problem hiding this comment.
has been be assigned
typo?
| @@ -1,5 +1,6 @@ | |||
| import { useFormContext } from "react-hook-form"; | |||
|
|
|||
| import { DatabricksSyncFields } from "@app/components/secret-syncs/forms/SecretSyncDestinationFields/DatabricksSyncFields"; | |||
There was a problem hiding this comment.
nit - consistent imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR adds support for Databricks Connections and Sync with documentation. In addition, App Connection & Secret Syncs have been alphabetized and minor variable name refactoring has been performed for code consistency.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets