Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 정식 경매 제품을 사전 경매 조회 시 조회되는 버그 수정 #88

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

junest66
Copy link
Collaborator

@junest66 junest66 commented Oct 14, 2024

#️⃣연관된 이슈

CHZZ-140

📝작업 내용

  • 정식 경매 제품의 productId로 사전 경매 조회시 조회되는 버그를 수정하였습니다.
  • 서비스에서 한번 검증하여 에러를 던졌습니다.
  • 쿼리 단에서 조건 추가하였습니다.

✅테스트 결과

image

🙏리뷰 요구사항(선택)

@junest66 junest66 added the 🐛bug 버그 발견 label Oct 14, 2024
@junest66 junest66 self-assigned this Oct 14, 2024
- 실패해도 jira bot이 auction를 스킵은 하나 실행은 해서 실패한걸 없애버림

CHZZ-140
Copy link
Collaborator

@YeaChan05 YeaChan05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰할때 제대로 못본거같네요
확인했습니다

Copy link
Member

@viaunixue viaunixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@YeaChan05 YeaChan05 merged commit cfcb3b2 into JECT-Study:develop Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug 버그 발견
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants