Lenient BedParser #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lenient parser logs the parsing errors and keeps going, strict parser throws an exception. Also added comments to parser's methods.
olegs
reviewed
May 30, 2019
As per pull request review suggestion
|
At the moment the default mode is LENIENT and all errors are hidden (debug logging usually is off) so a developer cannot figure out what percent of file was actually parsed, e.g. 2 lines of 100500 or 100% lines. Is it better to add some errors counter into BedParser or change default mode to strict one? |
|
Each line can:
We can offer those three numbers as properties of |
I think one is enough: |
Following the pull request review
|
Added the respective property and some tests for it. |
iromeo
reviewed
Jun 11, 2019
iromeo
reviewed
Jun 11, 2019
iromeo
reviewed
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to JetBrains-Research/jbr#62.
BedParsernow has stringency property. In lenient mode (default), the parser skips any lines it can't parse (it also logs them with debug level). In strict mode, the parser throws an exception on any such line. This new feature is covered by tests.Note: It's actually arguable whether we need strict mode at all. Thoughts are welcome.