JBR-8118 TextureWrapperImage for MTLTexture #513
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkartashev
reviewed
Feb 11, 2025
mkartashev
reviewed
Feb 11, 2025
src/java.desktop/share/classes/com/jetbrains/desktop/image/TextureWrapperImage.java
Show resolved
Hide resolved
avu
requested changes
Feb 11, 2025
src/java.desktop/macosx/classes/sun/java2d/MacosxSurfaceManagerFactory.java
Outdated
Show resolved
Hide resolved
YaaZ
reviewed
Feb 11, 2025
src/java.desktop/share/classes/com/jetbrains/desktop/image/TextureWrapperImage.java
Outdated
Show resolved
Hide resolved
MTLTextureWrapperSurfaceData: allocate var before rq.lock()
don't use * in imports
use UnsupportedOperationException in createTextureWrapperSurfaceManager
introduce SharedTextures service
ujpv
force-pushed
the
kharitonov/shared_textures_rebase
branch
from
f40d316 to
6dc24d6
Compare
use constant for texture type
mkartashev
requested changes
Feb 17, 2025
src/java.desktop/share/classes/com/jetbrains/desktop/SharedTextures.java
Outdated
Show resolved
Hide resolved
src/java.desktop/share/classes/com/jetbrains/desktop/image/TextureWrapperImage.java
Outdated
Show resolved
Hide resolved
src/java.desktop/unix/classes/sun/java2d/UnixSurfaceManagerFactory.java
Outdated
Show resolved
Hide resolved
use SunToolkit#isInstanceOf
mkartashev
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.