Support test resources in Compose UI tests. #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrakok
changed the title
igordmn
reviewed
Aug 27, 2024
...ces/library/src/androidMain/kotlin/org/jetbrains/compose/resources/AndroidContextProvider.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Aug 27, 2024
igordmn
reviewed
Aug 27, 2024
...ces/library/src/androidMain/kotlin/org/jetbrains/compose/resources/AndroidContextProvider.kt
Outdated
Show resolved
Hide resolved
|
Adding a second reviewer, as we have a new API |
|
@eymar, could you review the new API? |
eymar
reviewed
Aug 28, 2024
...ces/library/src/androidMain/kotlin/org/jetbrains/compose/resources/AndroidContextProvider.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Aug 28, 2024
...lugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt
Show resolved
Hide resolved
eymar
reviewed
Aug 28, 2024
|
|
||
| @Test | ||
| fun checkTestFileResource() { | ||
| runTest { |
There was a problem hiding this comment.
If this test would run on web eventually, runTest result should be returned from the function:
@Test
fun fooTest() = runTest { ... }The reason is: https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-test/kotlinx.coroutines.test/run-test.html
In the future (after 1.8), this requirement might affect runComposeUiTest too.
eymar
approved these changes
Aug 28, 2024
|
@igordmn I found a way how to get an instrumentation context without additional configuration. check the latest commit |
igordmn
approved these changes
Aug 28, 2024
… to set an instrumented context. This context helps `ResourceReader` access test assets in instrumented environments.
… configure test context
terrakok
force-pushed
the
k.tskh/test-resources
branch
from
dd83199
to
5a50c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-1470
Fixes https://youtrack.jetbrains.com/issue/CMP-5963
Release Notes
Features - Resources