[JEWEL-756] Investigate a11y limitations and missing features #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
changed the title
|
@hamen this needs rebasing. I'd recommend squashing all the commits into one, it's easier to keep up to date that way. We need this merged ASAP. |
fix a couple of parameters list order in Tabs replace thenIf in ComboBox remove Role.Button from MenuItem iterate on Checkbox add more semantics to RadioButton add some KDOC to SegmentedControl change SegmentedControlButton a11y role iterate on Dropdown a11y iterate on Banners a11y Add Explicit API mode to JPS build reference JetBrains#2926 (comment) Clean up Jewel dialogs in IDE reference JetBrains/jewel#754 Add missing JPS setup make the linter happy add Copyright to a bunch of files extract Tooltips extract TextFields extract TextAreas extract Tabs extract SplitLayouts extract Sliders extract SegmentedControls extract Scrollbars extract RadioButtons extract ProgressBar extract Links extract Icons extract Dropdowns extract Chips and Tree extract Checkboxes extract Buttons extract Borders extract Banners
rock3r
suggested changes
Feb 18, 2025
There was a problem hiding this comment.
I have a lot of questions on a lot of these changes... I don't know if I misunderstood how the content description should be used, or you've just been overzealously filling them in without considering where it's actually needed and where it isn't. Either way, I'd like to get confirmation before we proceed, to dispel my misunderstanding (which I'd be happy to learn) or to avoid unnecessarily verbose screen reader behaviour
...ain/kotlin/org/jetbrains/jewel/markdown/extensions/github/alerts/GitHubAlertBlockRenderer.kt
Outdated
Show resolved
Hide resolved
...wel/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Tabs.kt
Outdated
Show resolved
Hide resolved
...amples/standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/WelcomeView.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Tabs.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Menu.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Menu.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PlatformIcon.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SegmentedControl.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SimpleListItem.kt
Outdated
Show resolved
Hide resolved
rock3r
suggested changes
Feb 18, 2025
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/PlatformIcon.kt
Outdated
Show resolved
Hide resolved
rock3r
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, review and merge only after #2921
Reference JetBrains/jewel#756