Add handling for opening existing pull requests from notifications #2949
Conversation
|
@clemairej @iasemenov - I implemented the same in the AZD and it is working pretty well. I have issues with the Bazel - so can't test it but if you think it is ok I can do the same for the GitLab. Thanks a lot |
|
|
||
| return listOf(GHPRCreatePullRequestNotificationAction(project, projectMapping, account)) | ||
| } | ||
| ?: GitPushNotificationUtil.findRepositoryAndAccount(project.serviceAsync<GHHostedRepositoriesManager>().knownRepositories, repository, remoteBranch.remote, project.serviceAsync<GHAccountManager>().accountsState.value, project.serviceAsync<GithubPullRequestsProjectUISettings>().selectedUrlAndAccount?.second, project.serviceAsync<GithubProjectDefaultAccountHolder>().account) |
There was a problem hiding this comment.
Probably best not to include this reformatting, the line becomes a little long
I can change it and commit it if that's okay with you :)
|
Thanks! Looks fine to me :) |
|
@clemairej and @iasemenov would you like me to do the same for GitLab? If so in this PR or opening a new one? |
|
@Jonatha1983 If you're feeling motivated, I won't stop you :) |
|
@clemairej sure - same PR or new one? |
|
Oh right sorry. Let's do a new PR. Consider this one merged :) |
|
@clemairej oops... I tried to sync my repo and by mistake, it deleted this pr |
|
I ll create a new PR for this with the sync |
Enhanced notification actions to support detecting and opening existing pull requests directly from the GitHub plugin. If an existing PR is found, the corresponding tab in the tool window is opened instead of prompting to create a new one. This ensures better alignment of actions with repository context. closes #2949 GitOrigin-RevId: 9ad0b9c09db803d701248659f04de4483d4ca083
Enhanced notification actions to support detecting and opening existing pull requests directly from the GitHub plugin. If an existing PR is found, the corresponding tab in the tool window is suggested to be opened if it doesn't exist, a suggested notification popup to create a new one same as today. This ensures better alignment of actions with repository context.