Skip to content

Commit

Permalink
television resizer commits resize even during desync
Browse files Browse the repository at this point in the history
this prevents a visual resizing of the image at the moment when the
screen has synchronised. ie. the resizing happens and is disguised
by the synchronisation process

fixed spelling mistake in television preferences window
  • Loading branch information
JetSetIlly committed Nov 23, 2024
1 parent b54439e commit 2d6a6a5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion gui/sdlimgui/win_prefs_television.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ for it to be a valid VSYNC signal`)
receiving a valid VSYNC signal`)

imgui.Spacing()
prefsCheckbox(&win.img.dbg.VCS().Env.Prefs.TV.VSYNCimmediateDesync, "Immediate Dysynchronisation")
prefsCheckbox(&win.img.dbg.VCS().Env.Prefs.TV.VSYNCimmediateDesync, "Immediate Desynchronisation")
win.img.imguiTooltipSimple(`Desynchronise the screen immediately
when a VSYNC signal is late`)

Expand Down
9 changes: 6 additions & 3 deletions hardware/television/resizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,13 @@ func (rz *Resizer) commit(state *State) error {
rz.usingVBLANK = false
}()

// NOTE: we no longer do this because it sometimes causes a visual resize if
// the resize hasn't been caught by the preview process
//
// do not resize unless screen is synchronised
if !state.vsync.isSynced() {
return nil
}
// if !state.vsync.isSynced() {
// return nil
// }

// if top/bottom values this frame are not the same as pending top/bottom
// values then update pending values and reset pending counter.
Expand Down

0 comments on commit 2d6a6a5

Please sign in to comment.