Fixed node nullability and custom mutators

JoshuaKGoldberg · Mar 24, 2024 · a2d90bf · a2d90bf
1 parent fc69ef6
commit a2d90bf
Show file tree

Hide file tree

Showing 26 changed files with 242 additions and 173 deletions.
diff --git a/...completeTypes/fixIncompleteInterfaceOrTypeLiteralGenerics/collectGenericNodeReferences.ts b/...completeTypes/fixIncompleteInterfaceOrTypeLiteralGenerics/collectGenericNodeReferences.ts
@@ -268,7 +268,7 @@ const expressionRefersToOriginalType = (
 	// This can go wrong easily: e.g. with multiple type arguments that have intermixed usages
 	if (
 		isTypeArgumentsType(expressionNodeType) &&
-		expressionNodeType.typeArguments.includes(originalType)
+		expressionNodeType.typeArguments?.includes(originalType)
 	) {
 		return true;
 	}

diff --git a/src/runtime/providers/createCoreMutationsProvider.ts b/src/runtime/providers/createCoreMutationsProvider.ts
@@ -26,9 +26,6 @@ export const createCoreMutationsProvider = (
 		const enabledFixes = Object.keys(options.fixes).filter(
 			(key) => options.fixes[key as keyof typeof options.fixes],
 		);
-		if (!enabledFixes.length) {
-			return undefined;
-		}
 
 		const fileNamesAndServicesCache = createFileNamesAndServicesCache(options);
 		const waveTracker = new WaveTracker();

diff --git a/src/shared/typeNodes.ts b/src/shared/typeNodes.ts
@@ -24,7 +24,7 @@ export type TypeWithTypeArguments = ts.Type & {
 export const isTypeArgumentsType = (
 	type: ts.Type,
 ): type is TypeWithTypeArguments => {
-	return "typeArguments" in type;
+	return "typeArguments" in type && !!type.typeArguments;
 };
 
 export type TypeWithOptionalTypeArguments = ts.Type & {

diff --git a/test/cases/custom mutators/empty/expected.ts b/test/cases/custom mutators/empty/expected.ts
@@ -1,4 +1,4 @@
-(function() {
+(function () {
 	console.log("Hello, world!");
 
 	function ignoreChanges(): string {

diff --git a/test/cases/custom mutators/one/actual.ts b/test/cases/custom mutators/one/actual.ts
@@ -1,4 +1,4 @@
-(function () {
+/* foo */ (function () {
 	console.log("Hello, world!");
 
 	function ignoreChanges(): string {

diff --git a/test/cases/custom mutators/one/expected.ts b/test/cases/custom mutators/one/expected.ts
@@ -1,4 +1,4 @@
-/* foo */ (function() {
+/* foo */ (function () {
 	console.log("Hello, world!");
 
 	function ignoreChanges(): string {

diff --git a/test/cases/custom mutators/two/actual.ts b/test/cases/custom mutators/two/actual.ts
@@ -1,4 +1,4 @@
-(function () {
+/* 2 */ /* 1 */ (function () {
 	console.log("Hello, world!");
 
 	function ignoreChanges(): string {

diff --git a/test/cases/custom mutators/two/expected.ts b/test/cases/custom mutators/two/expected.ts
@@ -1,4 +1,4 @@
-/* 2 */ /* 1 */ (function() {
+/* 2 */ /* 1 */ (function () {
 	console.log("Hello, world!");
 
 	function ignoreChanges(): string {

diff --git a/test/cases/fixes/missingProperties/missingPropertyAccesses/actual.ts b/test/cases/fixes/missingProperties/missingPropertyAccesses/actual.ts
@@ -25,6 +25,5 @@ private _withGetterAndSetter: string;
 		get withGetterAndSetter() {
 			return this._withGetterAndSetter;
 		}
-
 	}
-})();
+})();
diff --git a/test/cases/fixes/missingProperties/missingPropertyAccesses/expected.ts b/test/cases/fixes/missingProperties/missingPropertyAccesses/expected.ts
@@ -25,6 +25,5 @@ private _withGetterAndSetter: string;
 		get withGetterAndSetter() {
 			return this._withGetterAndSetter;
 		}
-
 	}
-})();
+})();
diff --git a/test/cases/fixes/noInferableTypes/parameters/actual.ts b/test/cases/fixes/noInferableTypes/parameters/actual.ts
@@ -1,45 +1,60 @@
 (function () {
 	// Inferable literals
-	const inferableBoolean = (input = false) => { };
-	const inferableNull = (input = null) => { };
-	const inferableNumber = (input = 0) => { };
-	const inferableRegExp = (input = /./) => { };
-	const inferableString = (input = "") => { };
-	const inferableUndefined = (input = undefined) => { };
+	const inferableBoolean = (input = false) => {};
+	const inferableNull = (input = null) => {};
+	const inferableNumber = (input = 0) => {};
+	const inferableRegExp = (input = /./) => {};
+	const inferableString = (input = "") => {};
+	const inferableUndefined = (input = undefined) => {};
 
 	// Inferable arrays
-	const inferableBooleans = (input = [false]) => { };
-	const inferableNulls = (input = [null]) => { };
-	const inferableNumbers = (input = [0]) => { };
-	const inferableRegExps = (input = [/./]) => { };
-	const inferableStrings = (input = [""]) => { };
-	const inferableUndefineds = (input = [undefined]) => { };
+	const inferableBooleans = (input = [false]) => {};
+	const inferableNulls = (input = [null]) => {};
+	const inferableNumbers = (input = [0]) => {};
+	const inferableRegExps = (input = [/./]) => {};
+	const inferableStrings = (input = [""]) => {};
+	const inferableUndefineds = (input = [undefined]) => {};
 
 	// Inferable multi-type arrays
-	const inferableNullOrStrings = (input = [null, ""]) => { };
-	const inferableNumberOrRegExps = (input = [0, /./]) => { };
+	const inferableNullOrStrings = (input = [null, ""]) => {};
+	const inferableNumberOrRegExps = (
+		input = [0, /./],
+	) => {};
 
 	// Non-inferable multi-type arrays
-	const nonInferableNullOrStrings = (input: (null | string)[] = [null]) => { };
-	const nonInferableNumberOrRegExps = (input: (number | RegExp)[] = [0]) => { };
-
+	const nonInferableNullOrStrings = (input: (null | string)[] = [null]) => {};
+	const nonInferableNumberOrRegExps = (input: (number | RegExp)[] = [0]) => {};
 
 	// Class instances
 
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	// Inferable direct class instances
-	const takesParent = (parent = new Parent()) => { };
-	const takesChild = (child = new Child()) => { };
+	const takesParent = (parent = new Parent()) => {};
+	const takesChild = (child = new Child()) => {};
 
 	// Non-inferable direct class instances
-	const takesParentAsChild = (child: Parent = new Child()) => { };
+	const takesParentAsChild = (child: Parent = new Child()) => {};
 
 	// Non-inferable union class instances
-	const takesParentOrChildAsParent = (either: Parent | Child = new Parent()) => { };
-	const takesParentOrChildAsChild = (either: Parent | Child = new Child()) => { };
-	const takesParentOrUndefinedAsParent = (child: Parent | undefined = new Parent()) => { };
-	const takesParentOrUndefinedAsChild = (child: Parent | undefined = new Child()) => { };
-	const takesChildOrUndefinedAsChild = (child: Child | undefined = new Child()) => { };
-})();
+	const takesParentOrChildAsParent = (
+		either: Parent | Child = new Parent(),
+	) => {};
+	const takesParentOrChildAsChild = (
+		either: Parent | Child = new Child(),
+	) => {};
+	const takesParentOrUndefinedAsParent = (
+		child: Parent | undefined = new Parent(),
+	) => {};
+	const takesParentOrUndefinedAsChild = (
+		child: Parent | undefined = new Child(),
+	) => {};
+	const takesChildOrUndefinedAsChild = (
+		child: Child | undefined = new Child(),
+	) => {};
+})();
diff --git a/test/cases/fixes/noInferableTypes/parameters/expected.ts b/test/cases/fixes/noInferableTypes/parameters/expected.ts
@@ -1,45 +1,60 @@
 (function () {
 	// Inferable literals
-	const inferableBoolean = (input = false) => { };
-	const inferableNull = (input = null) => { };
-	const inferableNumber = (input = 0) => { };
-	const inferableRegExp = (input = /./) => { };
-	const inferableString = (input = "") => { };
-	const inferableUndefined = (input = undefined) => { };
+	const inferableBoolean = (input = false) => {};
+	const inferableNull = (input = null) => {};
+	const inferableNumber = (input = 0) => {};
+	const inferableRegExp = (input = /./) => {};
+	const inferableString = (input = "") => {};
+	const inferableUndefined = (input = undefined) => {};
 
 	// Inferable arrays
-	const inferableBooleans = (input = [false]) => { };
-	const inferableNulls = (input = [null]) => { };
-	const inferableNumbers = (input = [0]) => { };
-	const inferableRegExps = (input = [/./]) => { };
-	const inferableStrings = (input = [""]) => { };
-	const inferableUndefineds = (input = [undefined]) => { };
+	const inferableBooleans = (input = [false]) => {};
+	const inferableNulls = (input = [null]) => {};
+	const inferableNumbers = (input = [0]) => {};
+	const inferableRegExps = (input = [/./]) => {};
+	const inferableStrings = (input = [""]) => {};
+	const inferableUndefineds = (input = [undefined]) => {};
 
 	// Inferable multi-type arrays
-	const inferableNullOrStrings = (input = [null, ""]) => { };
-	const inferableNumberOrRegExps = (input = [0, /./]) => { };
+	const inferableNullOrStrings = (input = [null, ""]) => {};
+	const inferableNumberOrRegExps = (
+		input = [0, /./],
+	) => {};
 
 	// Non-inferable multi-type arrays
-	const nonInferableNullOrStrings = (input: (null | string)[] = [null]) => { };
-	const nonInferableNumberOrRegExps = (input: (number | RegExp)[] = [0]) => { };
-
+	const nonInferableNullOrStrings = (input: (null | string)[] = [null]) => {};
+	const nonInferableNumberOrRegExps = (input: (number | RegExp)[] = [0]) => {};
 
 	// Class instances
 
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	// Inferable direct class instances
-	const takesParent = (parent = new Parent()) => { };
-	const takesChild = (child = new Child()) => { };
+	const takesParent = (parent = new Parent()) => {};
+	const takesChild = (child = new Child()) => {};
 
 	// Non-inferable direct class instances
-	const takesParentAsChild = (child: Parent = new Child()) => { };
+	const takesParentAsChild = (child: Parent = new Child()) => {};
 
 	// Non-inferable union class instances
-	const takesParentOrChildAsParent = (either: Parent | Child = new Parent()) => { };
-	const takesParentOrChildAsChild = (either: Parent | Child = new Child()) => { };
-	const takesParentOrUndefinedAsParent = (child: Parent | undefined = new Parent()) => { };
-	const takesParentOrUndefinedAsChild = (child: Parent | undefined = new Child()) => { };
-	const takesChildOrUndefinedAsChild = (child: Child | undefined = new Child()) => { };
-})();
+	const takesParentOrChildAsParent = (
+		either: Parent | Child = new Parent(),
+	) => {};
+	const takesParentOrChildAsChild = (
+		either: Parent | Child = new Child(),
+	) => {};
+	const takesParentOrUndefinedAsParent = (
+		child: Parent | undefined = new Parent(),
+	) => {};
+	const takesParentOrUndefinedAsChild = (
+		child: Parent | undefined = new Child(),
+	) => {};
+	const takesChildOrUndefinedAsChild = (
+		child: Child | undefined = new Child(),
+	) => {};
+})();
diff --git a/test/cases/fixes/noInferableTypes/propertyDeclarations/actual.ts b/test/cases/fixes/noInferableTypes/propertyDeclarations/actual.ts
@@ -1,6 +1,10 @@
 (function () {
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	class ContainsInferables {
 		// Inferable literals
@@ -27,7 +31,6 @@
 		public nonInferableNullOrStrings: (null | string)[] = [null];
 		public nonInferableNumberOrRegExps: (number | RegExp)[] = [0];
 
-
 		// Class instances
 
 		// Inferable direct class instances
@@ -44,4 +47,4 @@
 		public takesParentOrUndefinedAsChild: Parent | undefined = new Child();
 		public takesChildOrUndefinedAsChild: Child | undefined = new Child();
 	}
-})();
+})();
diff --git a/test/cases/fixes/noInferableTypes/propertyDeclarations/expected.ts b/test/cases/fixes/noInferableTypes/propertyDeclarations/expected.ts
@@ -1,6 +1,10 @@
 (function () {
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	class ContainsInferables {
 		// Inferable literals
@@ -27,7 +31,6 @@
 		public nonInferableNullOrStrings: (null | string)[] = [null];
 		public nonInferableNumberOrRegExps: (number | RegExp)[] = [0];
 
-
 		// Class instances
 
 		// Inferable direct class instances
@@ -44,4 +47,4 @@
 		public takesParentOrUndefinedAsChild: Parent | undefined = new Child();
 		public takesChildOrUndefinedAsChild: Child | undefined = new Child();
 	}
-})();
+})();
diff --git a/test/cases/fixes/noInferableTypes/variableDeclarations/actual.ts b/test/cases/fixes/noInferableTypes/variableDeclarations/actual.ts
@@ -1,6 +1,10 @@
 (function () {
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	// Inferable const literals
 	const constInferableBoolean = false;
@@ -50,7 +54,6 @@
 	let letNonInferableNullOrStrings: (null | string)[] = [null];
 	let letNonInferableNumberOrRegExps: (number | RegExp)[] = [0];
 
-
 	// Class instances
 
 	// Inferable const direct class instances
@@ -80,4 +83,4 @@
 	let letTakesParentOrUndefinedAsParent: Parent | undefined = new Parent();
 	let letTakesParentOrUndefinedAsChild: Parent | undefined = new Child();
 	let letTakesChildOrUndefinedAsChild: Child | undefined = new Child();
-})();
+})();
diff --git a/test/cases/fixes/noInferableTypes/variableDeclarations/expected.ts b/test/cases/fixes/noInferableTypes/variableDeclarations/expected.ts
@@ -1,6 +1,10 @@
 (function () {
-	class Parent { parent = true; }
-	class Child extends Parent { child = true; }
+	class Parent {
+		parent = true;
+	}
+	class Child extends Parent {
+		child = true;
+	}
 
 	// Inferable const literals
 	const constInferableBoolean = false;
@@ -50,7 +54,6 @@
 	let letNonInferableNullOrStrings: (null | string)[] = [null];
 	let letNonInferableNumberOrRegExps: (number | RegExp)[] = [0];
 
-
 	// Class instances
 
 	// Inferable const direct class instances
@@ -80,4 +83,4 @@
 	let letTakesParentOrUndefinedAsParent: Parent | undefined = new Parent();
 	let letTakesParentOrUndefinedAsChild: Parent | undefined = new Child();
 	let letTakesChildOrUndefinedAsChild: Child | undefined = new Child();
-})();
+})();