-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] streamer type generation #18
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 77.22% 77.29% +0.07%
==========================================
Files 7 7
Lines 878 881 +3
==========================================
+ Hits 678 681 +3
Misses 200 200
Continue to review full report at Codecov.
|
Yes, there were a few (changing) naming conventions throughout. Some of the I really need to sit down and think about how to restructure and come up with an easy to follow/understand naming convention for |
Sorry for spamming; for the sake of completeness I'd like to link our discussion from last year #4 |
my question is there's no way to know about the ROOT built-in types such as |
Yes, exactly. That's what we call "bootstrapping". I got most of these hard coded definitions from |
will we ever encounter TTypes whose name we have never seen before? (i.e. not in ROOT base) We can't generate I actually couldn't find where uproot hard code the basic stuff :( |
Yes, I think those types are always provided "in source" and not "in file". The stuff in |
I think your original
TODO
had a typo? we are generating forreadfields!
it seems.We come up with a structure so we don't need to type out an entire
@eval function ....
in the_generate_T_Types
. This PR serves as a POC, and at least avoid hard-coding for each n inTType_n
variation