Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type inference issue in basket access #243

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

tamasgal
Copy link
Member

This PR separates the index calculation of normal baskets and recovered ones in two separate functions. The fix however for #242 comes from the fact that now the return types are defined to be a UnitRange{Int} for both of them.

I did not manage to write a test to check the correct type inference yet.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.04 ⚠️

Comparison is base (db2b306) 87.53% compared to head (25f7a87) 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   87.53%   87.50%   -0.04%     
==========================================
  Files          18       18              
  Lines        2279     2281       +2     
==========================================
+ Hits         1995     1996       +1     
- Misses        284      285       +1     
Impacted Files Coverage Δ
src/iteration.jl 85.23% <62.50%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tamasgal
Copy link
Member Author

I opened an issue to remind (myself) of type stability tests: #244

@tamasgal tamasgal merged commit 81007e1 into master Apr 24, 2023
@tamasgal tamasgal deleted the fix-type-inference-issue-in-basket-access branch April 24, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant