Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Affine distributions #1442

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
e8d191a
Add Affine distributions
ParadaCarleton Nov 28, 2021
7d2d5a7
Bug fixes
ParadaCarleton Nov 28, 2021
9106a9e
Fixes
ParadaCarleton Nov 28, 2021
acb57f1
Don't export Affine
ParadaCarleton Nov 28, 2021
25766de
Remove `affine` export
ParadaCarleton Nov 28, 2021
9d127b1
replace `affine`
ParadaCarleton Nov 28, 2021
22cb852
Update src/matrix/matrixfdist.jl
ParadaCarleton Nov 28, 2021
756ddc1
Update src/matrix/matrixtdist.jl
ParadaCarleton Nov 28, 2021
4dda88b
Update .gitignore
ParadaCarleton Nov 28, 2021
aefd9d2
suggestions
ParadaCarleton Nov 28, 2021
a71d351
Rename "Affine"
ParadaCarleton Nov 28, 2021
9f69cc6
documentation+exports
ParadaCarleton Nov 28, 2021
a969ae4
LocationScale bug? + convenient `affine`
ParadaCarleton Nov 28, 2021
ffad8aa
LocationScale bug?
ParadaCarleton Nov 28, 2021
9d73c17
Add multivariate affine (everything is broken tho)
ParadaCarleton Dec 2, 2021
0c5a89d
Only 20% broken now! (according to tests)
ParadaCarleton Dec 4, 2021
788bee9
Almost everything works now!
ParadaCarleton Dec 4, 2021
0ddf5ca
fixes
ParadaCarleton Dec 5, 2021
92083c1
minor changes
ParadaCarleton Dec 5, 2021
18cd1cb
Update src/common.jl
ParadaCarleton Dec 5, 2021
68a0bf2
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
3fe309b
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
10876c0
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
4409934
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
4884be5
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
78e4ed1
Apply suggestions
ParadaCarleton Dec 5, 2021
50703e0
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
0a77c2e
Update src/univariate/affine.jl
ParadaCarleton Dec 5, 2021
40b3dcf
Update src/univariate/affine.jl
ParadaCarleton Dec 6, 2021
62dbce6
fixes
ParadaCarleton Dec 7, 2021
c0f1143
add `rand!`
ParadaCarleton Dec 7, 2021
4d191d1
fixes
ParadaCarleton Dec 7, 2021
4b10ad3
Fixes
ParadaCarleton Dec 8, 2021
5129c58
additional test
ParadaCarleton Dec 8, 2021
82bc2ae
Update src/matrix/lkj.jl
ParadaCarleton Dec 8, 2021
2286772
Doc improvements
ParadaCarleton Dec 8, 2021
c4ad326
Remove qualified "inv"
ParadaCarleton Dec 8, 2021
cd9dcf6
Fix method ambiguity
ParadaCarleton Dec 8, 2021
4d6d7a2
Fix `CDF` for univariate distributions
ParadaCarleton Dec 8, 2021
775e2eb
Merge remote-tracking branch 'upstream/master' into affine-transforms
ParadaCarleton Dec 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix method ambiguity
ParadaCarleton committed Dec 8, 2021
commit cd9dcf668f81e0a80c2ea6aaf70f46d593e5aa2d
2 changes: 1 addition & 1 deletion src/univariate/affine.jl
Original file line number Diff line number Diff line change
@@ -101,7 +101,7 @@ function Base.:*(σ::Real, ρ::Distribution{<:ArrayLikeVariate})
return AffineDistribution(Zeros{eltype(σ)}(size(ρ)), σ, ρ)
end

function Base.:*(σ::AbstractMatrix{<:Real}, ρ::MultivariateDistribution)
function Base.:*(σ::AbstractMatrix, ρ::MultivariateDistribution)
if iszero(σ)
throw(ArgumentError("scale must be non-zero"))
end