Simplify and document convolve
#1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
- Coverage 84.44% 84.42% -0.02%
==========================================
Files 124 124
Lines 7462 7456 -6
==========================================
- Hits 6301 6295 -6
Misses 1161 1161
Continue to review full report at Codecov.
|
mschauer
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the seemingly uncontroversial changes in #1445: A simpler implementation of
convolve(::MvNormal, ::MvNormal)and documentation ofconvolve(preview: https://juliastats.org/Distributions.jl/previews/PR1452/convolution/).Hopefully splitting #1445 let's us merge and make available these improvements faster.