Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Expression widget to support the 'Show Your Work' hackathon project #1768

Closed
wants to merge 12 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/main' into expr-widget-hackathon
kevinb-khan committed Nov 1, 2024
commit 0f3349d0752713e3f4e9cc18ac2626fb6c35c297
5 changes: 2 additions & 3 deletions packages/perseus/src/components/math-input.tsx
Original file line number Diff line number Diff line change
@@ -68,9 +68,9 @@ type Props = {
* - `never` means that the keypad is **never shown**.
*/
buttonsVisible?: ButtonsVisibleType;
analytics: PerseusDependenciesV2["analytics"];
disabled?: boolean;
noBackground?: boolean;
onAnalyticsEvent: AnalyticsEventHandlerFn;
};

type InnerProps = Props & {
@@ -367,8 +367,7 @@ class InnerMathInput extends React.Component<InnerProps, State> {
>
<DesktopKeypad
onAnalyticsEvent={
this.props.analytics
.onAnalyticsEvent
this.props.onAnalyticsEvent
}
extraKeys={this.props.extraKeys}
onClickKey={this.handleKeypadPress}
You are viewing a condensed version of this merge commit. You can view the full changes here.