[2-quell-the-fracus] [Bug Fix] - Ensure that users hand typing tex into Numeric Inputs on Desktop do not cause an infinite loop. #2175
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Numeric Inputs on Desktop do not cause an infinite loop. I believe this solves the issue, but I'm putting this in a PR to perform some additional testing downstream. Issue: LEMS-198 Test Plan: - Run tests - New tex wrangler test
…reate infinite loop with incomplete tex in Numeric Input
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ff226d9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2175If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2175 |
|
Size Change: +112 B (+0.01%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
…reate infinite loop with incomplete tex in Numeric Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This ticket is part of the Numeric Input project.
Numeric Input has different experiences on Desktop versus Mobile:
This diverged experience resulted in the possibility to hit an infinite loop on Desktop if the user tries to hand type
\fracor\dfracTeX commands , as the parser was unable to locate the next symbols to parse. This has likely been a bug since inception, but has become far more noticeable as we're now parsing answers on the fly to provide AI support. As a result, the answers are constantly being evaluated and would hit the infinite loop as soon as the user started typing the expressions.Issue: LEMS-198
Test plan: