-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIPT (Just In Place Translation) fix up dependency types #879
base: main
Are you sure you want to change the base?
Conversation
Size Change: +55 B (+0.01%) Total Size: 866 kB
ℹ️ View Unchanged
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 58.53% 60.12% +1.58%
==========================================
Files 406 408 +2
Lines 99384 99400 +16
Branches 5979 8577 +2598
==========================================
+ Hits 58174 59763 +1589
+ Misses 41210 39637 -1573
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ecb6ac7
to
242530d
Compare
…rovide JIPT-support features
242530d
to
e2becec
Compare
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (2a23f20) and published it to npm. You Example: yarn add @khanacademy/perseus@PR879 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR879 |
graphieMovablesJiptLabels: JiptLabelStore; | ||
svgImageJiptLabels: JiptLabelStore; | ||
rendererTranslationComponents: JiptTranslationComponents; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These only make sense when useJIPT: true
, so I've moved these into the JIPT
type union when useJIPT: true
Summary:
Our JIPT configuration on the dependencies required the full JIPT configuration even when JIPT support was disabled (
useJIPT: false
). I've changed it so the types don't require the extra support functions when JIPT is not enabled. This makes the code clearer where we support this feature and should make dependency setup in host apps clearer as well.Issue: "none"
Test plan: