Add support for shared library build #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
makkarpov
force-pushed
the
main
branch
3 times, most recently
from
7b62fde
to
638331b
Compare
spencer-lunarg
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
LGTM - @chaoticbob mentioned how we should add a blurb to the README.md to mention this is possible and which cmake options to set
|
Ok, I will add mentions in README.md that shared library build is possible. Also, to be on the safe side, I will also perform DLL testing on Windows with actual application. It should work (GCC cross-compilation succeeded, all exports are present), but it's better to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building SPIRV-Reflect as a shared library.
Sure enough, this library is not a perfect candidate to be shared (i.e. stack-allocated structs without any kind of layout or size stability guarantees), but at least this PR makes library usable via FFI interface from languages like Java.