Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop option that gzips files server side #724

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Drop option that gzips files server side #724

merged 3 commits into from
Oct 16, 2024

Conversation

leplatrem
Copy link
Contributor

Reasons to drop this option:

  • less code
  • not self served (requires config change)
  • costs CPU
  • can create confusion with CDN Gzip
  • not used in remote settings

alexcottner
alexcottner approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed linting error and removed some code that's no longer touched. This looks good to me now.

@leplatrem leplatrem merged commit df13ff9 into main Oct 16, 2024
5 checks passed
@leplatrem leplatrem deleted the drop-gzip-support branch October 16, 2024 08:02
@leplatrem leplatrem mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

@grahamalama grahamalama Awaiting requested review from grahamalama

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @alexcottner