Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser-based authentication method #375

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Add browser-based authentication method #375

merged 5 commits into from
Nov 14, 2024

Conversation

leplatrem
Copy link
Contributor

See https://bugzilla.mozilla.org/show_bug.cgi?id=1630651
This will allow us to publish data from mozilla-central using ./mach.

This works as expected:

>>> import kinto_http
>>> c = kinto_http.Client(server_url='https://remote-settings-dev.allizom.org/v1', auth=kinto_http.BrowserOAuth())
>>> c.server_info()["user"]

I wonder if there is a less hacky way to accomplish this. Any idea?

Copy link

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. We might want to adjust our coverage requirements.

Copy link

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@leplatrem leplatrem merged commit cf0251e into main Nov 14, 2024
6 checks passed
@leplatrem leplatrem deleted the login-method branch November 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants