Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a button for adding or deleting a section in resume from UI itself. #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Anurag519Narula
Copy link

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

@Anurag519Narula
Copy link
Author

@Kishan-Ved please have a look. Merge the PR if you feel everything is right. Thanks!

@Kishan-Ved
Copy link
Owner

We already have a checkbox to add or remove the internships section. Let's keep it consistant throughout for all sections. Please add checkboxes for every section, rather than these buttons:
image

@Anurag519Narula
Copy link
Author

Hi @Kishan-Ved , please have a look now, I have made changes and have done the deleting and adding section by a checkbox

@Anurag519Narula
Copy link
Author

Hi @Kishan-Ved please merge.

@Kishan-Ved
Copy link
Owner

Uncheck skills and copy the latex code, it still shows skills in the latex pdf. This is a bug, check for similar bugs.

@Anurag519Narula
Copy link
Author

Hi @Kishan-Ved , have fixed the bug and checked, everything is working fine, please have a look. Thanks!

@Anurag519Narula
Copy link
Author

Hi @Kishan-Ved , is everything working fine?

Copy link
Owner

@Kishan-Ved Kishan-Ved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some content in all sections (remember to click on Add This), now uncheck all of them, the Latex code is correct, but the preview still shows the entered data. Please fix this. Also, upon unchecking the internships' checkbox, the header still remains in the preview.

Another bug: Add some data to internships, click on add this. Now, uncheck the checkbox. The data remains in the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants