Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nyholm/psr7 dependency #2648

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove nyholm/psr7 dependency #2648

merged 1 commit into from
Jan 8, 2025

Conversation

williamjallen
Copy link
Collaborator

nyholm/psr7 appears to be unused. This PR removes it from our list of dependencies.

@williamjallen williamjallen added this to the v3.8 milestone Jan 3, 2025
josephsnyder
josephsnyder approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are still a number of references to the package in the composer.lock file but they all seem to be in one of require-dev, suggested, or conflict .

@josephsnyder josephsnyder added this pull request to the merge queue Jan 8, 2025
Merged via the queue into Kitware:master with commit 1e702a4 Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: maintenance
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder