Reformat test dependencies #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration is well-tested at this point, and should never need to change.
Some of these tests require the database to be set up.
zackgalbreath
approved these changes
Jan 16, 2025
This was referenced Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
#2664 allowed CTest to have more flexibility regarding the ordering of tests. That exposed an issue with the `BuildTypeTest` which relied upon more than just data it created. This PR resolves the issue by restricting the test to use only the data it creates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the oldest issues relates to the poor design of the CDash test suite. Many tests have implicit dependencies upon one another. Out of an abundance of caution, dependencies were added between all of the legacy tests to ensure that they continue to run in the expected order, while allowing new tests to run in parallel. As the number of new parallelizable tests has grown, the dependency structure has become unmanageable. The eventual solution is to write independent tests whenever possible, using
FIXTURES_REQUIREDin combination withRESOURCE_LOCKfor cases where tests need to have exclusive access to the.envor database. This PR is a stepping stone towards that goal by removing unnecessary test dependencies and creating dedicated places to put new independent tests.