-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔀 Add "Use a main router" advice #5
base: main
Are you sure you want to change the base?
Conversation
That's not exactly what I would recommend (naming wise). I prefer to call the directory |
@Kludex to clarify this point, the fastapi.FastAPI object ("app") is located in |
@Kludex bump? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I want to include this, because I think what's needed is a more structural advice than just the routing.
But here's my review... I'm nitpicking because I think this repository is supposed to be very opinionated.
Sorry the delay. It's been hard. |
Co-authored-by: Marcelo Trylesinski <[email protected]>
I really like your suggestions, I approved everything.
No worries.
A major issue in software is organization, structure of repository and projects. I consider this, if simple in essence, primordial in order to have a clean, well organized project. |
I think this repository is a good idea!
Here is my first contribution, more oriented around code and file layout than technical stuff. However, this approach has been very helpful to me and teammates over the past few years.
What do you think?