-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(konnect): KongTarget reconciler #627
Conversation
12e3487
to
bafaf00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid 👍
Please add a sample manifest in config/samples/
for Upstream with Target so that users know how this can be used (and also so that it's tested via:
gateway-operator/.github/workflows/tests.yaml
Lines 69 to 96 in 83369ea
samples: | |
runs-on: ubuntu-latest | |
steps: | |
- name: Checkout repository | |
uses: actions/checkout@v4 | |
- name: Setup go | |
uses: actions/setup-go@v5 | |
with: | |
go-version-file: go.mod | |
- name: Create k8s KinD Cluster | |
uses: helm/[email protected] | |
- uses: jdx/mise-action@v2 | |
with: | |
install: false | |
# We use install.all to install all CRDs and resources also the ones that are not bundled | |
# in base kustomization (e.g. currently AIGateway) but which have samples defined. | |
- name: Verify installing CRDs via kustomize works | |
run: make install.all | |
- name: Install and delete each sample one by one | |
run: make test.samples | |
- name: Verify that uninstalling operator CRDs via kustomize works | |
run: make uninstall.all |
When rebasing please use the functions to set programmed condition on entities introduced in #633. |
f0c949c
to
3ea4f61
Compare
Done and added sample |
3ea4f61
to
f39a1eb
Compare
What this PR does / why we need it:
Add
KongTarget
reconciler to reconcileKongTarget
s.Which issue this PR fixes
Major part of #576
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes