feat: added snis new empty state #1941
Conversation
| /** | ||
| * Enables the new empty state design, this prop can be removed when | ||
| * the khcp-14756-empty-states-m2 FF is removed. | ||
| */ | ||
| enableV2EmptyStates: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
issue: no feature flag usage should be mentioned in this PR, and props shouldn't be tied to "versions" of things but rather linked to the overall functionality being added.
Prop removal creates a need for breaking change releases when the prop is removed; is that desired here?
There was a problem hiding this comment.
Do these new empty states only get shown in Konnect? What's the behavior in Kong Manager that uses these same components? (this comment should block all of the open PRs until resolved)
There was a problem hiding this comment.
This PR enables the new empty states only for konnect ( we have added app config check for the new empty state and its also guarded by the FF via prop ). The KM will still show the old empty states.
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
Summary
SNI new Empty state
FF : khcp-14756-empty-states-m2