Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unirest compatible to mime 2.* versions #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gayathridmallela
Copy link

This is to support the higer versoin of mime from 2.* .This fix is required to avoid the error of mandate true on the mine on the retries

To avoid the below error on retries callback

Error: Attempt to change mapping for "form" extension from "application/x-www-form-urlencoded" to "application/x-www-form-urlencoded". Pass force=true to allow this, otherwise remove "form" from the list of extensions for "application/x-www-form-urlencoded".
at Mime.define (/home/user/projects/mytest/node_modules/mime/Mime.js:32:17)

This is to support the higer versoin of mime from 2.* .This fix is required to avoid the error of mandate true on the mine on the retries
@gayathridmallela gayathridmallela changed the title Update index.js Make unirest compatible to mime 2.* versions Feb 26, 2020
@crispinkoech
Copy link

crispinkoech commented Aug 14, 2020

Hey, any update on this? Facing this issue on one of our packages 😅 @nijikokun

@nijikokun
Copy link
Contributor

Appears that one of the tests is failing, once resolved I can merge

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants